Skip to content

fix: show negative sign for inflation change dropdown option#583

Merged
rickstaa merged 1 commit intomainfrom
fix/inflation-change-dropdown-typo
Mar 8, 2026
Merged

fix: show negative sign for inflation change dropdown option#583
rickstaa merged 1 commit intomainfrom
fix/inflation-change-dropdown-typo

Conversation

@rickstaa
Copy link
Member

@rickstaa rickstaa commented Mar 8, 2026

Summary

  • Fixed the "Inflation change" dropdown on the Orchestrators page showing two identical "+0.00005% per round" options
  • The negative option now correctly displays "-0.00005% per round" by negating the value when the "negative" change type is selected

Closes #582

Test plan

  • Verify the dropdown shows three distinct options: "Fixed at 0.063%", "+0.00005% per round", "-0.00005% per round"
  • Verify selecting the negative option correctly applies negative inflation change to ROI calculations

🤖 Generated with Claude Code

The "Inflation change" dropdown on the Orchestrators page displayed
two identical "+0.00005% per round" options. The negative option now
correctly shows "-0.00005% per round" by negating the value when the
"negative" change type is selected.

Closes #582

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rickstaa rickstaa requested a review from ECWireless as a code owner March 8, 2026 07:57
Copilot AI review requested due to automatic review settings March 8, 2026 07:57
@vercel
Copy link
Contributor

vercel bot commented Mar 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
explorer-arbitrum-one Ready Ready Preview, Comment Mar 8, 2026 7:59am

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Orchestrators page “Inflation change” dropdown so the negative option displays a negative percentage (instead of duplicating the positive label), aligning the UI with the underlying ROI model’s negative-change behavior.

Changes:

  • Update formatPercentChange to negate inflationChange when the "negative" option is selected.
  • Ensure the dropdown renders three distinct labels (fixed / positive / negative) via signed percent formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rickstaa rickstaa merged commit ab0b7c8 into main Mar 8, 2026
12 checks passed
@rickstaa rickstaa deleted the fix/inflation-change-dropdown-typo branch March 8, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inflation change dropdown shows duplicate positive values

2 participants