Initial UniFFI C++ Bindgen - #1389
Draft
alan-george-lk wants to merge 2 commits into
Draft
Conversation
alan-george-lk
force-pushed
the
alan/feature-uniffi-cpp
branch
2 times, most recently
from
September 8, 2026 22:05
54329d0 to
a6646fa
Compare
alan-george-lk
changed the title
alan-george-lk
force-pushed
the
alan/feature-uniffi-cpp
branch
from
September 9, 2026 15:11
3674716 to
a2f8242
Compare
alan-george-lk
force-pushed
the
alan/feature-uniffi-cpp
branch
from
September 9, 2026 20:08
a2f8242 to
e7bc2c4
Compare
alan-george-lk
changed the title
alan-george-lk
commented
Sep 10, 2026
| # uniffi-exposing crates (livekit-ffi, livekit-uniffi, ...). It has no library | ||
| # target — the bindgens read metadata from an already-compiled cdylib via | ||
| # `--library`, so they never depend on the crates they generate for. | ||
| # Tooling crate: each bin is a code-generation CLI shared across the workspace. |
Contributor
Author
There was a problem hiding this comment.
I think AI adjusted this because I told it I wasn't leveraging livekit-uniffi anymore, I can revert
Contributor
There was a problem hiding this comment.
Yea I think reverting that makes sense!
1egoman
approved these changes
Sep 10, 2026
| # uniffi-exposing crates (livekit-ffi, livekit-uniffi, ...). It has no library | ||
| # target — the bindgens read metadata from an already-compiled cdylib via | ||
| # `--library`, so they never depend on the crates they generate for. | ||
| # Tooling crate: each bin is a code-generation CLI shared across the workspace. |
Contributor
There was a problem hiding this comment.
Yea I think reverting that makes sense!
Comment on lines
+29
to
+30
| const REPOSITORY: &str = "https://github.com/alan-george-lk/uniffi-bindgen-cpp.git"; | ||
| const REVISION: &str = "7d54c1c56e0e4c46772ef4c2b5be3cb26396cbdb"; |
Contributor
There was a problem hiding this comment.
suggestion: If this will be long lived, it probably makes sense to move this under https://github.com/livekit and move to an explicit tag once it is stable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
livekit-ffivia Nord Bindgen fork workTesting