yuv-sys: actionable error when libyuv submodule is not initialized - #1347
Open
zacha7214 wants to merge 3 commits into
Open
yuv-sys: actionable error when libyuv submodule is not initialized#1347zacha7214 wants to merge 3 commits into
zacha7214 wants to merge 3 commits into
Conversation
Added a check to ensure the libyuv submodule is initialized before proceeding.
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A fresh
git clonewithout--recursiveleavesyuv-sys/libyuvempty. The build script copies the empty directory and fails several calls later with:thread 'main' panicked at yuv-sys/build.rs:140:10:
called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
Nothing in the error points at the submodule as the cause, and the README build instructions don't mention
--recursive. CI/container builds don't hit this because the Dockerfile initializes submodules explicitly — it only affects local builds from a fresh clone.Fix
Check for
libyuv/include/libyuv.hbefore the copy and panic with the remedy.Verification
git submodule deinit -f yuv-sys/libyuv→ build fails with the new messagegit submodule update --init→ clean build succeeds (macOS, aarch64)