Skip to content

TEL-912: Return TransferSIPParticipantResponse on TransferSIPParticipantRequests - #786

Open
genseric-ghiro wants to merge 3 commits into
mainfrom
genseric/tel-912-transfer-response
Open

TEL-912: Return TransferSIPParticipantResponse on TransferSIPParticipantRequests#786
genseric-ghiro wants to merge 3 commits into
mainfrom
genseric/tel-912-transfer-response

Conversation

@genseric-ghiro

Copy link
Copy Markdown
Contributor

Summary

  • Now returning a response for TransferSIPParticipant
  • This was previously empty, even though the return type was set to SIPParticipantInfo, which was wrong, and resulted in systematic SIPParticipantInfo(participant_id="", participant_identity="", room_name="", sip_call_id="") responses.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@u9g

u9g commented Aug 24, 2026

Copy link
Copy Markdown

The type-check failure here is not from your change. The submodule bump to 17c16cf picks up SimulationRun.List.Request / SimulationRun.Counts.Request, which had a field named from — a Python keyword, so protoc's --pyi_out drops the attribute and falls back to an untyped **kwargs, which this repo's strict mypy rejects. Mine to fix, not yours: livekit/protocol#1738 renames the field. Once that merges, re-bump the submodule and regenerate and the two agent_simulation.pyi errors go away.

@genseric-ghiro
genseric-ghiro force-pushed the genseric/tel-912-transfer-response branch from ebd53bd to f03986d Compare August 24, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants