Skip to content

Remove extraneous format specifier from log message. #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexfish8 merged 2 commits into from
Jul 24, 2026
Merged

Remove extraneous format specifier from log message. #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4514cca
Fix log string.
alexfish8 Jul 24, 2026
5ec60db
Add changeset.
alexfish8 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/small-eggs-itch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"github.com/livekit/protocol": patch
"@livekit/protocol": patch
---

Remove extraneous format specifier from log string.
4 changes: 2 additions & 2 deletions livekit/sip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,15 +346,15 @@ func (vr ValidationResult) WithError(err error) ValidationResult {
// returns the result's associated error, if any.
func (vr ValidationResult) LogSoftErrors(l logger.Logger) error {
for _, err := range vr.softErrs {
l.Warnw("soft validation failure: %w", err)
l.Warnw("soft validation failure", err)
}
return vr.err
}

// LogUnlikelySoftErrors is a variant of LogSoftErrors.
func (vr ValidationResult) LogUnlikelySoftErrors(l logger.UnlikelyLogger) error {
for _, err := range vr.softErrs {
l.Warnw("soft validation failure: %w", err)
l.Warnw("soft validation failure", err)
}
return vr.err
}
Expand Down
Loading