feat: add simulation/redaction fields to MetricsRecordingHeader#1679
Merged
chenghao-mou merged 4 commits intoJul 21, 2026
Merged
Conversation
Lets the agent tag a recording upload as a simulation session and/or force PII redaction on, so the collector can skip (or force) redaction per session. `simulation` is derived agent-side from the job's lk.simulator.dispatch attribute; `redaction` from RecordingOptions. Reserves field 2 (removed observability field, #1294). AGT-3158 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 08663fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Lets the agent tag a recording upload as a simulation session and/or force PII redaction on, so the collector can skip (or force) redaction per session. simulated is derived agent-side from the job's lk.simulator.dispatch attribute; redaction_enabled from RecordingOptions. Reserves field 2 (removed observability field, #1294). AGT-3158 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chenghao-mou
marked this pull request as ready for review
July 21, 2026 14:46
theomonnom
approved these changes
Jul 21, 2026
chenghao-mou
deleted the
chenghao/feat/AGT-3158-recording-header-sim-redaction
branch
July 21, 2026 17:13
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: the collector needs to know, per recording upload, whether a session is a simulation (skip PII redaction) or has redaction force-enabled. These are known agent-side (from the job's
lk.simulator.dispatchattribute andRecordingOptions) but had no field on the recording header.What: adds two bool fields to
MetricsRecordingHeader:simulated(9) andredaction_enabled(10), and reserves the removed observability field 2.Note
downstream PRs (livekit/agents#6497, agents-private pii-redaction #221, cloud-observability #510) pin this branch via pseudo-version until it lands.
Part of AGT-3158.