Skip to content

fix(cloudagents): extend attributes to CreateAgent #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
s-hamdananwar wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(cloudagents): extend attributes to CreateAgent #945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions cmd/lk/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,11 @@
return err
}

attrs, err := resolveDeployAttributes(ctx, cmd)
if err != nil {
return err
}

imageRef := cmd.String("image")
imageTar := cmd.String("image-tar")
// Prebuilt image: no local project layout is required; skip language/dockerfile/sdk checks.
Expand All @@ -651,10 +656,6 @@
return err
}
out.Statusf("Created agent with ID [%s]", util.Accented(agentID))
attrs, err := resolveDeployAttributes(buildContext, cmd)
if err != nil {
return err
}
return deployPrebuiltImage(buildContext, agentID, imageRef, imageTar, attrs)
}

Expand Down Expand Up @@ -686,7 +687,7 @@
regions := []string{region}

excludeFiles := []string{fmt.Sprintf("**/%s", config.LiveKitTOMLFile)}
resp, err := agentsClient.CreateAgent(buildContext, os.DirFS(workingDir), secrets, regions, excludeFiles, os.Stderr)
resp, err := agentsClient.CreateAgent(buildContext, os.DirFS(workingDir), secrets, regions, attrs, excludeFiles, os.Stderr)

Check failure on line 690 in cmd/lk/agent.go

View workflow job for this annotation

GitHub Actions / lk agent with node agent on ubuntu-latest 

too many arguments in call to agentsClient.CreateAgent

Check failure on line 690 in cmd/lk/agent.go

View workflow job for this annotation

GitHub Actions / lk agent with python agent on macos-latest 

too many arguments in call to agentsClient.CreateAgent

Check failure on line 690 in cmd/lk/agent.go

View workflow job for this annotation

GitHub Actions / lk agent with python agent on ubuntu-latest 

too many arguments in call to agentsClient.CreateAgent

Check failure on line 690 in cmd/lk/agent.go

View workflow job for this annotation

GitHub Actions / lk agent with node agent on macos-latest 

too many arguments in call to agentsClient.CreateAgent

Check failure on line 690 in cmd/lk/agent.go

View workflow job for this annotation

GitHub Actions / Cross-build Windows artifacts (zig) 

too many arguments in call to agentsClient.CreateAgent

Check failure on line 690 in cmd/lk/agent.go

View workflow job for this annotation

GitHub Actions / Cross-build Windows artifacts (zig) 

too many arguments in call to agentsClient.CreateAgent

Check failure on line 690 in cmd/lk/agent.go

View workflow job for this annotation

GitHub Actions / test (macos-latest) 

too many arguments in call to agentsClient.CreateAgent

Check failure on line 690 in cmd/lk/agent.go

View workflow job for this annotation

GitHub Actions / Build darwin (native) 

too many arguments in call to agentsClient.CreateAgent
if err != nil {
if errors.Is(err, context.DeadlineExceeded) {
return fmt.Errorf("build timed out possibly due to large image size")
Expand Down
Loading