Repository navigation
Conversation
S-Sebb
requested review from
changt,
cloudwebrtc,
hiroshihorie and
xianshijing-lk
as code owners
November 22, 2026 18:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1308
Adds a public
LocalTrackSubscribedQualityUpdatedEvent(RoomEvent,ParticipantEvent): the server updated the requested layers and codecs of a local track.participant,publication, andqualities(Map<String, Map<VideoQuality, bool>>, per codec; fromsubscribedCodecs, or fromsubscribedQualitiesunder the track's own codec when the codec list is empty).setPublishingCodecs/setPublishingLayershave run, so an app reacting to it doesn't race them. The layer map is taken before they run: for SVC codecssetPublishingLayersForSendermarks every listed layer enabled in place, and the event reports what the server asked for. With dynacast off it is emitted without applying anything.Tests
test/core/room_e2e_test.dart: aSubscribedQualityUpdatefor a local publication emits the event with the codec's layer map (dynacast off); with dynacast on and a VP9 sender, the event keeps the requestedHIGH: falsewhile the sender keeps both layers active (this one fails if the map is taken after the layers are applied); and an update for an unknown sid emits nothing.