Repository navigation
Conversation
S-Sebb
requested review from
changt,
cloudwebrtc,
hiroshihorie and
xianshijing-lk
as code owners
November 22, 2026 18:01
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1306
LKAudioSwitchManagersetsAudioManager.mode = audioModeafterswitch.activate()whenmanageAudioFocusis false, instart()and in the live reconfigure path. audioswitch only sets the mode while it takes focus.deactivate()still restores the mode saved atactivate(). TheAudioManagercomes fromgetSystemService(Context.AUDIO_SERVICE), which works on API 21.Apps that pass
manageAudioFocus: falsewithout anaudioModenow get the defaultMODE_IN_COMMUNICATION; passaudioMode: AndroidAudioMode.normalto keep the old behaviour.An alternative is to fix this in audioswitch, setting the mode in
activate()whether or not focus is managed.