Repository navigation
Republish the remaining tracks and finish the reconnect when one track fails to republish #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
j-mercker
wants to merge
2
commits into
livekit:main
Choose a base branch
from
j-mercker:j-mercker/republish-failure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| patch type="fixed" "A track that fails to republish after a full reconnect no longer leaves the tracks after it unpublished or the room without a `RoomReconnectedEvent`. The failure is logged and the remaining tracks are republished" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Camera restarts after Unpublish all
While microphone republish waits, Unpublish all misses the camera in
rePublishAllTracks’s private snapshot. After the microphone times out, the loop publishes the camera despite the user’s stop request.Learn more
The example app’s Unpublish all control calls
unpublishAllTracks()after confirmation and remains available on the room page during reconnect. unpublishAllTracks only sees entries intrackPublications. rePublishAllTracks clears that map before waiting for the first publish, so an unpublish request during that wait never reaches the queued camera. Before this change, a timeout on the first track stopped the loop, leaving the queued camera unpublished. Now the loop attempts the camera after the timeout, without honoring the completed Unpublish all request.Example: A participant reconnects with microphone and camera enabled. While the microphone waits for its publish response, they confirm Unpublish all. The microphone times out, but the server answers the camera’s publish request, so video resumes.
Recommended fix: Make
unpublishAllTracks()cancel pending reconnect publications as well as registered publications. Check that cancellation before attempting each queued track and reconcile any publish already in flight. Test Unpublish all during a pending microphone republish followed by a timeout, and assert that the camera never publishes.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The race is real, but it isn't new. On
mainthe same thing happens whenever the microphone republish succeeds:rePublishAllTracks()has already clearedtrackPublications, sounpublishAllTracks()during the wait can't see the queued camera. This PR only extends it to the case where the first republish fails. Cancelling queued republishes needs a cancellation hook inrePublishAllTracks(), which seems better as its own change.