chore: remove unused ATTR_START_TIME, ATTR_END_TIME, and ATTR_SESSION_OPTIONS telemetry constants - #6934
Open
detail-app[bot] wants to merge 1 commit into
Conversation
…_OPTIONS telemetry constants
longcw
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove three dead telemetry span attribute constants from
trace_types.py along with their commented-out call sites in
agent_session.py and stale SAFE_KEYS entries in test_trace_types_pii.py.
in agent_session.py were commented out in favor of OpenTelemetry's
native span start_time/end_time parameters, leaving the constants
with zero production references (only commented-out lines).
span setup was refactored; the constant had no remaining references.
History
Dead Code PRs can be configured here.