Skip to content

chore: remove unused ATTR_START_TIME, ATTR_END_TIME, and ATTR_SESSION_OPTIONS telemetry constants - #6934

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-attr-start-time-attr-end-time-167376
Open

chore: remove unused ATTR_START_TIME, ATTR_END_TIME, and ATTR_SESSION_OPTIONS telemetry constants#6934
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-attr-start-time-attr-end-time-167376

Conversation

@detail-app

@detail-app detail-app Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Remove three dead telemetry span attribute constants from
trace_types.py along with their commented-out call sites in
agent_session.py and stale SAFE_KEYS entries in test_trace_types_pii.py.

  • ATTR_START_TIME / ATTR_END_TIME: their active set_attribute call sites
    in agent_session.py were commented out in favor of OpenTelemetry's
    native span start_time/end_time parameters, leaving the constants
    with zero production references (only commented-out lines).
  • ATTR_SESSION_OPTIONS: its sole call site was removed when the session
    span setup was refactored; the constant had no remaining references.

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner August 20, 2026 21:08
@detail-app
detail-app Bot requested a review from theomonnom August 20, 2026 21:08

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants