Skip to content

chore: remove unused JobExecutor id property #6933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detail-app wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −14
Open

chore: remove unused JobExecutor id property #6933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions livekit-agents/livekit/agents/ipc/job_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@


class JobExecutor(Protocol):
@property
def id(self) -> str: ...

@property
def started(self) -> bool: ...

Expand Down
7 changes: 1 addition & 6 deletions livekit-agents/livekit/agents/ipc/job_proc_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from ..job import JobContext, JobProcess, RunningJobInfo
from ..log import logger
from ..telemetry import metrics
from ..utils import aio, log_exceptions, shortuuid
from ..utils import aio, log_exceptions
from . import channel, proto
from .inference_executor import InferenceExecutor
from .job_executor import JobStatus
Expand Down Expand Up @@ -63,11 +63,6 @@ def __init__(
self._session_end_timeout = session_end_timeout
self._inference_executor = inference_executor
self._inference_tasks: set[asyncio.Task[None]] = set()
self._id = shortuuid("PCEXEC_")

@property
def id(self) -> str:
return self._id

@property
def process_kind(self) -> SupervisedProcKind:
Expand Down
5 changes: 0 additions & 5 deletions livekit-agents/livekit/agents/ipc/job_thread_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,6 @@ def __init__(
self._thread: threading.Thread | None = None
self._inference_executor = inference_executor
self._inference_tasks: set[asyncio.Task[None]] = set()
self._id = utils.shortuuid("THEXEC_")

@property
def id(self) -> str:
return self._id

@property
def status(self) -> JobStatus:
Expand Down