Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Bnowako
commented
Apr 14, 2026
|
|
||
| telemetry.metrics._update_worker_load(self._worker_load) | ||
| if self._prometheus_multiproc_dir: | ||
| if ( |
Author
There was a problem hiding this comment.
This check could be confusing, I don't like it but not sure how to improve it for now
Im wondering If we even need multiproc setup, as we are collecting AgentServer metrics which is just 1 process, if yes potentially otel setup needs change now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complementary otel setup for Agent Server metrics.
It's enabled when either
"OTEL_EXPORTER_OTLP_METRICS_ENDPOINT" | "OTEL_EXPORTER_OTLP_ENDPOINT"env var is setThe only thing I did not understood quite is multiproc prometheus setup, as agent server has only 1 process and the load_task is running there. Would appreciate help there!
Lmk if we should default to livekit o11y url
related issue: #5443