fix: skip OTLP log exporter setup when recording is disabled#4892
Open
theomonnom wants to merge 3 commits intomainfrom
Open
fix: skip OTLP log exporter setup when recording is disabled#4892theomonnom wants to merge 3 commits intomainfrom
theomonnom wants to merge 3 commits intomainfrom
Conversation
davidzhao
reviewed
Feb 19, 2026
livekit-agents/livekit/agents/job.py
Outdated
| or options.get("audio", True) | ||
| or options.get("transcript", True) | ||
| ) | ||
| if not needs_cloud: |
Member
There was a problem hiding this comment.
should this be: needs_cloud and not is_cloud(..)?
Move the is_cloud check from the top-level guard into the combined condition with needs_cloud, so the early return is: if not (needs_cloud and is_cloud(url)) This is cleaner and addresses the PR review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.