Close HttpServer client connections when draining#4878
Open
mfazalul wants to merge 1 commit intolivekit:mainfrom
Open
Close HttpServer client connections when draining#4878mfazalul wants to merge 1 commit intolivekit:mainfrom
mfazalul wants to merge 1 commit intolivekit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the agent server is deployed with Telegraf scraping the /metrics endpoint with default configs, there is a persistent connection kept alive indefinitely. When a
SIGTERMcommand is sent, it is unable to shut down the agent server gracefully and it gets stuck in the "process exiting" stage. This PR fixes the issue by calling close_client.Unfortunately,
close_clientsis only available with Python versions >= 3.13. I haven't been able to identify a similar fix for versions 3.10 to 3.12 which LiveKit supports.An alternative fix is to set Telegraf configs to close and start new connections with each scrape:
Tested via: