Add support for pocket plugin in pyproject.toml and update mypy configuration for pocket_tts module#4836
Add support for pocket plugin in pyproject.toml and update mypy configuration for pocket_tts module#4836dvalle08 wants to merge 2 commits intolivekit:mainfrom
Conversation
…guration for pocket_tts module
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9991bfd9bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if not producer_task.done(): | ||
| producer_task.cancel() | ||
| with contextlib.suppress(BaseException): | ||
| await producer_task |
There was a problem hiding this comment.
When synthesis times out or is cancelled, this finalizer only calls producer_task.cancel() on an asyncio.to_thread task; cancellation does not stop the underlying worker thread, so generate_audio_stream(...) can keep running after _push_generated_audio exits and releases _generation_lock. In practice, a request that hits conn_options.timeout can leave a background generation active while the next request starts, defeating the serialization guarantee and causing concurrent model access/thread leaks under repeated timeouts.
Useful? React with 👍 / 👎.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
2 participants
This PR introduces a new livekit-plugins-pocket integration that adds support for the Kyutai Pocket TTS model in LiveKit Agents.