fix(job): fix lambda closure capture and init failure tracking#4832
Open
SezginKahraman wants to merge 1 commit intolivekit:mainfrom
Open
fix(job): fix lambda closure capture and init failure tracking#4832SezginKahraman wants to merge 1 commit intolivekit:mainfrom
SezginKahraman wants to merge 1 commit intolivekit:mainfrom
Conversation
Contributor
SezginKahraman
commented
Feb 15, 2026
SezginKahraman
commented
- Fix race condition in participant task cleanup where lambda captured p.identity by reference instead of by value, causing the callback to use a potentially stale identity if the participant object changes
- Track job initialization failures in ThreadJobExecutor: log warnings for timeout/exception cases and set job status to FAILED instead of incorrectly reporting SUCCESS
- Fix race condition in participant task cleanup where lambda captured p.identity by reference instead of by value, causing the callback to use a potentially stale identity if the participant object changes - Track job initialization failures in ThreadJobExecutor: log warnings for timeout/exception cases and set job status to FAILED instead of incorrectly reporting SUCCESS Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
davidzhao
reviewed
Feb 17, 2026
Member
davidzhao
left a comment
davidzhao
left a comment
There was a problem hiding this comment.
the job status change makes sense. could you run make fix to clean up the formatting issues?
| task = asyncio.create_task(coro(self, p), name=task_name) | ||
| self._participant_tasks[(p.identity, coro)] = task | ||
| task.add_done_callback( | ||
| lambda _, coro=coro: self._participant_tasks.pop((p.identity, coro)) # type: ignore |
Member
There was a problem hiding this comment.
I don't think it's possible for a particular participant obj to change its identity.. why is this needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.