speech_handle's _wait_for_generation hangs forever if cancelled before playout#4085
Open
simllll wants to merge 1 commit intolivekit:mainfrom
Open
speech_handle's _wait_for_generation hangs forever if cancelled before playout#4085simllll wants to merge 1 commit intolivekit:mainfrom
simllll wants to merge 1 commit intolivekit:mainfrom
Conversation
e627b63 to
8028dcc
Compare
Contributor
|
a related fix #3169 to avoid deadlock when speech is interrupted before I am wondering do you see any other issues caused by |
Author
|
With this fix in place, I had no further issues in typescript. I haven't looked at the other PR in detail,but I'm pretty sure it's not applied in the TS version and therefore I was not affected by it. This fix is quite easy, and I can't see any side effects so far. What we could question: what is when a speech out is playing,and cancelled, .. while wait for generation is running. But as we cancel it anyway, I guess there is nothing wrong with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a speech handle gets cancelled before the playout has started, it's "on the queue", and authorization is cleared, but then the _wait_for_generation is never finished.
I'm not sure if this is the real fix, but at least it works..maybe someone of the python gurus has a better idea?
I had this issue already in the typescript version, but was wondering why there is nothing like this in the python version... and now I also stumbled upon this in the PY version.
see also livekit/agents-js#842
Added a test suite to reproduce the issue.
disclaimer: new to agent's python sdk ;-)