refactor(llm): unify ToolError contract for arg validation#1607
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
refactor(llm): unify ToolError contract for arg validation#1607rosetta-livekit-bot[bot] wants to merge 1 commit into
rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unifies tool-argument validation under a single
ToolErrorcontract owned byprepare_function_arguments, and fixes a malformed-JSON propagation bug along the way.prepare_function_argumentswrapsValidationError/ValueError/TypeErrorasToolError("Error parsing arguments for ..."), so the message the LLM sees is owned in one place.fnc_call: FunctionCall | Noneparameter. When provided andjson_argumentsis a string, the canonical JSON (post json_repair) is written back tofnc_call.argumentsbefore pydantic validation runs. This way, even when validation later fails, the conversation history holds valid JSON instead of the broken raw payload — without this, providers like Vertex/OpenAI reject the next request with a 5xx when re-serializing it (#5807 review).execute_function_calldrops its dedicated(ValidationError, ValueError)branch — oneprepare_function_arguments(..., fnc_call=fnc_call)call covers both parse failures and validation failures.ToolProxyToolset._handle_calldrops its own try/except wrapper and passes the parameters dict directly (no extrajson.dumps).fnc_call.Extracted from #5711.