fix(voice): restrict stt pipeline reuse#1605
Open
rosetta-livekit-bot[bot] wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: f7bbebf The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On agent handoff,
_detach_reusable_resourcesreuses the STT pipeline whentype(self.agent).stt_node is type(new_activity.agent).stt_node. That check passes whenever two agents share the samestt_nodemethod object — including via a common base class — but the detached pipeline is a running generator bound to the old agent'sself. The defaultAgent.stt_nodeis safe because it only readsself/activityat startup, before the yield loop. Any custom override that touchesself.sessionorself.activityinside the loop will crash after handoff:Tighten the precondition to "both agents use
Agent.stt_nodedirectly." Custom overrides — even ones shared via inheritance — no longer trigger reuse, since we can't verify they're safe to keep iterating after their boundselfloses its activity.