fix(IPC): graceful handling when channel closes during inference#1132
Open
haroldfabla2-hue wants to merge 2 commits intolivekit:mainfrom
Open
fix(IPC): graceful handling when channel closes during inference#1132haroldfabla2-hue wants to merge 2 commits intolivekit:mainfrom
haroldfabla2-hue wants to merge 2 commits intolivekit:mainfrom
Conversation
When the IPC channel closes during an inference request (normal during shutdown, disconnect, or reconnection), the job process was crashing with an unhandled exception. This change makes the error message more descriptive and logs at debug level instead of crashing. The error now clearly indicates this is an expected scenario during normal operation. Fixes: livekit#1080
🦋 Changeset detectedLatest commit: f4c4a7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Alberto Farah seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
@haroldfabla2-hue Can you fix the lint error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the IPC channel closes during an inference request (which happens during normal shutdown scenarios like participant disconnect, room close, or reconnection), the job process was crashing with an unhandled exception.
Changes
Related Issue
Fixes #1080
Testing
This fix addresses the regression introduced in 1.0.48 where was modified to throw on inference requests. The change makes the error handling consistent with other call sites in the codebase that correctly use
safeSendwithout throwing.