Drop PHP 8.1 - #248
Open
samuelwei wants to merge 8 commits into
Open
Drop PHP 8.1#248samuelwei wants to merge 8 commits into
samuelwei wants to merge 8 commits into
Conversation
samuelwei
commented
Jul 21, 2026
samuelwei
commented
- Drop PHP 8.1
- Bump dev tools
- phpstan: v1 -> v2
- phpunit: v11 -> v12
- rector: v1 -> v2
- psalm: v5 -> v6
# Conflicts: # src/Parameters/CreateMeetingParameters.php
samuelwei
force-pushed
the
drop-php-8.1
branch
from
September 21, 2026 16:00
259685f to
f82805f
Compare
samuelwei
force-pushed
the
drop-php-8.1
branch
from
September 21, 2026 16:01
f82805f to
cc46c56
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
============================================
- Coverage 98.09% 96.49% -1.60%
+ Complexity 454 420 -34
============================================
Files 54 57 +3
Lines 1049 999 -50
============================================
- Hits 1029 964 -65
- Misses 20 35 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FelixJacobi
requested changes
Sep 22, 2026
| * Get the cookie name. | ||
| */ | ||
| public function getName(): string | ||
| public function getName(): string|bool|int|null |
Member
There was a problem hiding this comment.
This and getters here should be narrowed by using assert, since Name never contains bool/int/null.
Author
There was a problem hiding this comment.
The setCookie class contained many features we don't need at all. I reduced it to the basics, which makes type safety a lot easier. 9834be8
samuelwei
force-pushed
the
drop-php-8.1
branch
from
October 2, 2026 08:33
9834be8 to
29166dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.