Repository navigation
fix(serializers): accept frozendict operands in lazy type-encoder registry - #922
Merged
Merged
Conversation
…istry Python 3.15 stubs add frozendict overloads to dict.__or__/__ror__, which made the narrower _LazyTypeEncoders overrides fail mypyc type-checking and broke every py3.15 mypyc wheel build.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 629 629
Lines 142408 142408
Branches 30808 30808
=======================================
+ Hits 120530 120531 +1
Misses 15241 15241
+ Partials 6637 6636 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Python 3.15 mypyc wheel builds. The 3.15 type stubs add
frozendictoverloads todict.__or__/__ror__. The lazy type-encoder registry overrides those methods with narrower signatures, so mypyc rejected them and every 3.15 wheel build failed before compiling.dictbehaves at runtime (it returnsNotImplementedfor operands it doesn't handle).__ior__, which only existed because of the old__or__signature mismatch.