Skip to content

refactor: retract storage staging and expose destination resolution - #740

Merged
cofin merged 6 commits into
mainfrom
refactor/storage-staging-retraction
Sep 10, 2026
Merged

refactor: retract storage staging and expose destination resolution#740
cofin merged 6 commits into
mainfrom
refactor/storage-staging-retraction

Conversation

@cofin

@cofin cofin commented Sep 10, 2026

Copy link
Copy Markdown
Member

The storage staging API had no adapter implementations, and job lookup always returned None. Remove those unsupported APIs and staging capability flags while preserving working Arrow transfers, returned job handles, and partition telemetry.

Add resolve_destination() to both storage pipelines. It returns an address and protocol for native object-store integrations, preserves direct remote URIs, resolves registered alias prefixes once, and applies backend path checks to local destinations. Update the storage reference and changelog.

Validation: interpreted storage/driver tests, lint/type checks, Sphinx, and compiled resolver tests pass. Full interpreted coverage is running; the broader compiled unit suite has failures undergoing comparison with the base commit.

@codecov-commenter

codecov-commenter commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.18%. Comparing base (0f2a9bc) to head (38ed0dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   77.14%   77.18%   +0.03%     
==========================================
  Files         486      486              
  Lines       69826    69772      -54     
  Branches     9681     9677       -4     
==========================================
- Hits        53870    53851      -19     
+ Misses      12501    12469      -32     
+ Partials     3455     3452       -3     
Flag Coverage Δ
integration 60.58% <50.00%> (+0.02%) ⬆️
py3.10 75.47% <100.00%> (+0.03%) ⬆️
py3.11 75.47% <100.00%> (+0.03%) ⬆️
py3.12 75.48% <100.00%> (+10.58%) ⬆️
py3.13 75.47% <100.00%> (+0.02%) ⬆️
py3.14 76.40% <100.00%> (+0.04%) ⬆️
unit 65.25% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sqlspec/adapters/bigquery/config.py 87.67% <ø> (-0.17%) ⬇️
sqlspec/adapters/spanner/config.py 87.45% <ø> (-0.05%) ⬇️
sqlspec/config.py 93.91% <ø> (-0.02%) ⬇️
sqlspec/driver/_async.py 81.18% <ø> (+0.52%) ⬆️
sqlspec/driver/_sync.py 79.52% <ø> (+0.54%) ⬆️
sqlspec/storage/__init__.py 100.00% <ø> (ø)
sqlspec/storage/pipeline.py 94.65% <100.00%> (+8.46%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cofin
cofin force-pushed the refactor/storage-staging-retraction branch from ca309be to 38ed0dc Compare September 10, 2026 20:31
@cofin
cofin merged commit 7ddfe41 into main Sep 10, 2026
23 checks passed
@cofin
cofin deleted the refactor/storage-staging-retraction branch September 10, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants