Skip to content

fix: unify Litestar configuration types - #739

Merged
cofin merged 2 commits into
mainfrom
fix/litestar-config-unification
Sep 10, 2026
Merged

cofin merged 2 commits into
mainfrom
fix/litestar-config-unification

Conversation

@cofin

@cofin cofin commented Sep 10, 2026

Copy link
Copy Markdown
Member

The public Litestar extension config now re-exports the complete canonical type, so session_table=True and all supported plugin options type-check through either import path. Remove the superseded wrap_exceptions helper and its dedicated tests; the typed adapter exception handlers remain unchanged.

Validated with 109 Litestar tests, 49 exception tests, make lint (including mypy and pyright), and make docs. The rendered reference includes all 32 fields, and coverage of the remaining exception code is unchanged.

@codecov-commenter

codecov-commenter commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.14%. Comparing base (f3b9637) to head (832ae89).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   75.94%   77.14%   +1.20%     
==========================================
  Files         486      486              
  Lines       69879    69826      -53     
  Branches     9682     9681       -1     
==========================================
+ Hits        53071    53870     +799     
+ Misses      13381    12501     -880     
- Partials     3427     3455      +28     
Flag Coverage Δ
integration 60.57% <100.00%> (+2.22%) ⬆️
py3.10 75.43% <100.00%> (-0.02%) ⬇️
py3.11 75.44% <100.00%> (-0.02%) ⬇️
py3.12 75.44% <100.00%> (+10.51%) ⬆️
py3.13 75.44% <100.00%> (+10.52%) ⬆️
py3.14 76.37% <100.00%> (+12.00%) ⬆️
unit 65.21% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sqlspec/exceptions.py 91.21% <ø> (-0.71%) ⬇️
sqlspec/extensions/litestar/config.py 100.00% <100.00%> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cofin
cofin merged commit 0f2a9bc into main Sep 10, 2026
23 checks passed
@cofin
cofin deleted the fix/litestar-config-unification branch September 10, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants