Skip to content

revert: fix(aiosqlite): commit pending transactions on pool release #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cofin merged 1 commit into from
Feb 10, 2026
Merged

revert: fix(aiosqlite): commit pending transactions on pool release #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions sqlspec/adapters/aiosqlite/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,11 +679,10 @@ async def release(self, connection: AiosqlitePoolConnection) -> None:
return

try:
# Auto-commit pending transactions on release (matches sqlite adapter behavior).
# Without this, DML executed outside explicit begin/commit is silently rolled back.
# Fast path: skip timeout wrapper for reset, just do the rollback directly
# The rollback itself is fast for SQLite; timeout is overkill for hot path
with suppress(Exception):
if connection.connection.in_transaction:
await connection.connection.commit()
await connection.connection.rollback()
connection.idle_since = time.time() # mark_as_idle inline
self._queue.put_nowait(connection)
except Exception as e:
Expand Down
Loading