fix(aiosqlite): commit pending transactions on pool release #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f rolling back The aiosqlite pool unconditionally rolled back on connection release, silently discarding DML changes made without explicit commit. This caused INSERT ... RETURNING to appear successful but never persist. Align with the sqlite adapter by committing if in_transaction on release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
commit(). This causedINSERT ... RETURNINGviaselect_one_or_noneto appear successful (returning an ID) but never persist the row to disk.release()method to commit ifin_transactioninstead of unconditionally rolling back, matching the sqlite adapter's behavior.