-
-
Notifications
You must be signed in to change notification settings - Fork 6
docs: 173 usage configuration #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added docs/examples/usage/test_configuration_22.txt with migration CLI commands - Replaced inline Migration CLI block in docs/usage/configuration.rst with a literalinclude to the new file - Inserted psycopg literalinclude in docs/usage/configuration.rst (reusing examples/usage/test_configuration_5.py) - Updated documentation TODOs accordingly Signed-off-by: euri10 <benoit.barthelet@gmail.com>
This reverts commit 0ff5c15.
…nto 173_usage_configuration
| "session_key": "db_session", | ||
| "pool_key": "db_pool", | ||
| "commit_mode": "autocommit", | ||
| "enable_correlation_middleware": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@euri10 i meant to bring this up you and @provinzkraut. I've removed it from sqlspec, but I think it needs to be something we include as an official middleware in Litestar. This will let us and others leverage the a correlation ID in their logs. I can add it back here if it's something we don't want in Litestar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly i dont have any form stand on this
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
- Deleted outdated test configuration examples for asyncpg and psycopg. - Added new example configurations for SQLite, asyncpg, psycopg, asyncmy, and DuckDB. - Introduced environment-based configuration examples for better flexibility. - Updated documentation references to point to the new example files. - Enhanced test cases to cover various best practices, including connection pooling, caching, and resource cleanup. - Improved clarity and organization of configuration examples for better usability.
This reverts commit 4629000.
|
@cofin you have any idea as to why i only see one file changed in this PR ?
|

Description
Closes
fixes #173