Skip to content

Conversation

@euri10
Copy link
Collaborator

@euri10 euri10 commented Nov 5, 2025

Description

Closes

fixes #173

- Added docs/examples/usage/test_configuration_22.txt with migration CLI commands

- Replaced inline Migration CLI block in docs/usage/configuration.rst with a literalinclude to the new file

- Inserted psycopg literalinclude in docs/usage/configuration.rst (reusing examples/usage/test_configuration_5.py)

- Updated documentation TODOs accordingly

Signed-off-by: euri10 <benoit.barthelet@gmail.com>
This reverts commit 0ff5c15.
@euri10 euri10 changed the title 173 usage configuration docs: 173 usage configuration Nov 5, 2025
"session_key": "db_session",
"pool_key": "db_pool",
"commit_mode": "autocommit",
"enable_correlation_middleware": True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@euri10 i meant to bring this up you and @provinzkraut. I've removed it from sqlspec, but I think it needs to be something we include as an official middleware in Litestar. This will let us and others leverage the a correlation ID in their logs. I can add it back here if it's something we don't want in Litestar.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly i dont have any form stand on this

cofin and others added 7 commits November 5, 2025 16:40
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Co-authored-by: Cody Fincher <204685+cofin@users.noreply.github.com>
- Deleted outdated test configuration examples for asyncpg and psycopg.
- Added new example configurations for SQLite, asyncpg, psycopg, asyncmy, and DuckDB.
- Introduced environment-based configuration examples for better flexibility.
- Updated documentation references to point to the new example files.
- Enhanced test cases to cover various best practices, including connection pooling, caching, and resource cleanup.
- Improved clarity and organization of configuration examples for better usability.
@euri10 euri10 marked this pull request as ready for review November 11, 2025 14:50
@euri10
Copy link
Collaborator Author

euri10 commented Nov 11, 2025

@cofin you have any idea as to why i only see one file changed in this PR ?
feels like a github ui issue ?

20251111_1551_1326x883_1762872685

@euri10 euri10 merged commit 46f58d4 into litestar-org:main Nov 11, 2025
10 checks passed
@euri10 euri10 deleted the 173_usage_configuration branch November 11, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: test ./usage/configuration.rst

2 participants