SSR: Fix SSR Table in authoring.md to reflect more recent info#1481
Open
KonnorRogers wants to merge 1 commit into
Open
SSR: Fix SSR Table in authoring.md to reflect more recent info#1481KonnorRogers wants to merge 1 commit into
KonnorRogers wants to merge 1 commit into
Conversation
- Adds note about `connectedCallback` - https://github.com/lit/lit/blob/ada3ffce30cdb6a2f9a9d476767eaf747a0b2667/packages/labs/ssr/src/lib/lit-element-renderer.ts#L150-L153 - Fixes `firstUpdate` to `firstUpdated` - https://lit.dev/docs/components/lifecycle/#firstupdated - Fixes `update` to reflect it *is* called during SSR. https://github.com/lit/lit/blob/ada3ffce30cdb6a2f9a9d476767eaf747a0b2667/packages/labs/ssr/src/lib/lit-element-renderer.ts#L180
KonnorRogers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectedCallback- https://github.com/lit/lit/blob/ada3ffce30cdb6a2f9a9d476767eaf747a0b2667/packages/labs/ssr/src/lib/lit-element-renderer.ts#L150-L153firstUpdatetofirstUpdated- https://lit.dev/docs/components/lifecycle/#firstupdatedupdateto reflect it is called during SSR. https://github.com/lit/lit/blob/ada3ffce30cdb6a2f9a9d476767eaf747a0b2667/packages/labs/ssr/src/lib/lit-element-renderer.ts#L180