Update default.conf.sample to deny dotfile access - #47
Conversation
Signed-off-by: Eric Nemchik <eric@nemchik.com>
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
Signed-off-by: Eric Nemchik <eric@nemchik.com>
There was a problem hiding this comment.
Pull request overview
Updates the container’s default Nginx site configuration with the goal of preventing accidental exposure of dotfiles (e.g., .env, .git, .ht*) and informs existing users via the changelog.
Changes:
- Add a generic dotfile-deny
locationrule and an exception for/.well-known. - Add QUIC/HTTP3
listendirectives on 443/udp. - Update the README changelog variables to notify existing users of the config change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| root/defaults/nginx/site-confs/default.conf.sample | Adds dotfile blocking, a /.well-known exception, and QUIC listen directives. |
| readme-vars.yml | Adds a changelog entry instructing users to update their nginx site config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Allow access to the ".well-known" directory | ||
| location ^~ /.well-known { | ||
| allow all; | ||
| } | ||
|
|
||
| # deny access to all dotfiles | ||
| location ~ /\. { |
| location ^~ /media/ { | ||
| root /app/www/public; | ||
| } | ||
|
|
||
| location ^~ /static/ { | ||
| location ^~ /static/ { | ||
| root /app/www/public; | ||
| } |
| "babybuddy:latest" <- Base Images | ||
| # changelog | ||
| changelogs: | ||
| - {date: "08.02.26:", desc: "Existing users should update: site-confs/default.conf - Deny access to all dotfiles."} |
| listen 443 ssl default_server; | ||
| listen [::]:443 ssl default_server; | ||
| listen 443 quic reuseport default_server; | ||
| listen [::]:443 quic reuseport default_server; |
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR for commit 817c3f2 :
|
|
I am a bot, here are the test results for this PR for commit 2eee974 :
|
|
I am a bot, here are the test results for this PR for commit 98529bc :
|
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
No description provided.