feat: Add Wayland support for Chromium browser StartupWMClass #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Wayland, Chromium ignores the --class flag and uses its own app_id
format: chrome-{domain}__-{profile}. This breaks dock icon matching
since webapp-manager sets StartupWMClass=WebApp-*.
Changes:
- Add is_wayland_session() to detect Wayland via XDG_SESSION_TYPE
or WAYLAND_DISPLAY
- Add get_chromium_wayland_class() to generate the correct app_id
- Update create_webapp and edit_webapp to use Wayland-specific class
for Chromium browsers
- Update webapp detection to recognize StartupWMClass=chrome-* entries
- Add unit tests for Wayland and X11 behavior
Chrome includes the URL path in the app_id, not just the domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Wayland, Chromium ignores the --class flag and uses its own app_id
format: chrome-{domain}__-{profile}. This breaks dock icon matching
since webapp-manager sets StartupWMClass=WebApp-*.
Changes: