Conversation
…multiple files. initial_permission_state_consistent() stored the full mode of the first file but compared the other files against it after masking, so with more than one file the initial state never looked consistent. Enabling a permission checkbox then went to the 'mixed' state and restored the original permissions, and only the second click actually applied the change. Fixes linuxmint#3641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3641
initial_permission_state_consistent() kept the full mode of the first file but compared the others after masking, so with more than one file the state never looked consistent and the first click just put the original permissions back.
tested on Mint 22.3 with two 0644 files: before, the first click on "Allow executing file as program" left both at 0644. with the fix it sets 0755 right away. same for the advanced r/w/x boxes, single files and mixed selections behave as before