Fixes in "printers@cinnamon.org" by hans-fritz-pommes · Pull Request #13524 · linuxmint/cinnamon

hans-fritz-pommes · 2026-02-01T18:34:28Z

I encountered several small issues with the printers applet.
I modified the applet.js in /usr/share/cinnamon/applets/printers@cinnamon.org and tested printing documents.
The things I did correct:

The "Cancel all jobs" command didn't work for an user who had no permisisons to run cancel -a for a specific printer, even if all of the jobs on this printer belonged to him.
-> Now the "Cancel all jobs" command tries to cancel every single job, not cancel -a for every printer
The appearance of the listed jobs was really bad: e.g. when you had more than one job, the description for every job was "<desc. first job><desc. second job><desc..." and so on.
The job description consisted of: (job number) lpstat -o (lpstat several times, if there was more than one job - see point before)
-> The description is now: (job number) 'document_name' on <printer_name> (<size in Bytes/MB/KB>) by <user> (using lpq -a).

~~The following problem could occur:~~
~~If a job has the same number as byte-size like the job-id of the following one, the username and the filesize of the first one will be strange (job-id and functions stay working).~~
~~I would say this will happen that seldom - we should ignore it.~~
~~Which user will open the menu exactly in that minute and have a problem with a strange username or filesize?~~

EDIT: fixed in new commit

hans-fritz-pommes · 2026-02-01T18:38:47Z

Oh and I changed icons. If you think they're ugly, just revert it

hans-fritz-pommes · 2026-02-01T19:19:15Z

I have an idea how to fix this mini-problem (identical bytes & job-number). But later

Fix mini-problem (See linuxmint#13524)

hans-fritz-pommes · 2026-02-01T20:55:53Z

Ok, now the identical bytes/document-name & job-number-problem is fixed.

hans-fritz-pommes · 2026-02-02T12:37:16Z

Sorry that I'm so chaotic
I forgot to take care of document names with whitespaces

Support filenames with whitespaces

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js

github-actions · 2026-03-05T08:22:56Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 1 potential issue(s):

⚠️ lang_bind

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:218

Util.spawn_async(['/usr/bin/lpq', '-a'], Lang.bind(this, function(out2) {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

Automated pattern check.

Improved with mtwebsters ideas (linuxmint#13524)

github-actions · 2026-03-05T08:58:50Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 1 potential issue(s):

⚠️ lang_bind

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:203

Util.spawn_async(['/usr/bin/lpq', '-a'], Lang.bind(this, function(out2) {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

Automated pattern check.

hans-fritz-pommes · 2026-03-05T08:59:46Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or maintainability issues, or that may already be provided by Cinnamon. Having code flagged by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 1 potential issue(s):

⚠️ lang_bind

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:218
Util.spawn_async(['/usr/bin/lpq', '-a'], Lang.bind(this, function(out2) {
Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

Automated pattern check.

What should be done with that?

leigh123linux · 2026-03-05T10:20:20Z

Please squash the commits into one.

mtwebster · 2026-03-05T12:25:27Z

What should be done with that?

What it suggests - use an arrow function instead of using Lang.bind(). Look at other applets, it's a pretty straightforward change.

removed deprecated lang.bind

hans-fritz-pommes · 2026-03-05T13:55:21Z

By the way:
I was wondering why ever lpstat was used for gathering the job-data.
This pull request removed lpq. I thought every system having lpstat also has lpq since it's a part of cups?

Adressed linuxmint#9265

Adressing linuxmint#9265 Necessary update to catch the error reason

hans-fritz-pommes · 2026-03-09T16:43:36Z

Those new commits intend to make it compatible with a turned-off CUPS-service

hans-fritz-pommes · 2026-03-09T16:44:21Z

Please squash the commits into one.

~~I will do that when merging~~

🤦oups merging is not my task, right?

improved error handling

added this.removed

removed unnecessary timeout

hans-fritz-pommes · 2026-03-10T15:09:23Z

Now the guy from #13039 shouldn't have problems anymore with missing lpq and there shouldn't be a problem with missing / not running cups (#9265).

improved looking of error-handling

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js

mtwebster · 2026-03-10T16:53:35Z

Can we drop the python script? util.spawnCommandLineAsyncIO() should work fine in this case - they're all fixed arguments. Sorry I should have caught this earlier...

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js

- exchanged "Util.spawn_async(...)" & "tool.py" with "Util.spawnCommandLineAsyncIO(...)" - exchanged "GLib.format_size_for_display(...)" with "GLib.format_size(...)" - exchanged "cancel-print-dialog.py" with "ModalDialog.ConfirmDialog"

github-actions · 2026-03-11T20:00:40Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 5 potential issue(s):

ℹ️ shell_string_spawn

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:181

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -a', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:192

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -l', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:214

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -d', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:242

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -o', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:265

Util.spawnCommandLineAsyncIO('/usr/bin/lpq -a', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

Automated pattern check.

hans-fritz-pommes · 2026-03-11T20:20:55Z

Can we drop the python script? util.spawnCommandLineAsyncIO() should work fine in this case - they're all fixed arguments. Sorry I should have caught this earlier...

Why would it be insecure if there were user inputs?
And why is there no function with argv and the possibility to catch stdout, stderr and exitCode?

(It's just about understanding)

hans-fritz-pommes · 2026-03-11T20:23:32Z

Ah and I replaced the second python script - this means now we don't have Gtk-dialogs anymore. Instead: A Cinnamon modal dialog.

mtwebster · 2026-03-11T21:13:11Z

Why would it be insecure if there were user inputs?

You can get a lot more info with Google or asking AI to explain shell injection vulnerabilities... but basically,

This is safe - it will always run exactly that command, you're using a static string.

Util.spawnCommandLineAsyncIO('/usr/bin/lpq -a', ()=>{});

but, for example filename restrictions are fairly lax...

let file = file.get_basename() // '; dangerous-command ~'
let cmd = "ls -la " + file;
Util.spawnCommandLineAsyncIO(file, ()=>{}); // ls -la ; dangerous-command ~

That example is pretty extreme and unlikely, but it's a real concern, and we're all better off being in the habit of using argv variants in the first place, to prevent misinterpretation like this.

And why is there no function with argv and the possibility to catch stdout, stderr and exitCode?

Because I didn't notice it was missing before implementing our pattern checker here - I'll be adding one for sure. You could use GLib.spawn_async_with_pipes or Gio.Subprocess api directly (which is what spawnCommandLineAsyncIO uses internally), but they're much less convenient to setup and use. For your purposes here, it's ok.

replaced error message cut 69 with 70 removed unnecessary line with printError = falsr;

hans-fritz-pommes · 2026-03-12T15:27:23Z

Should I port to spawnAsyncIO or just leave it?

github-actions · 2026-03-15T18:14:03Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 5 potential issue(s):

ℹ️ shell_string_spawn

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:180

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -a', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:191

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -l', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:213

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -d', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:241

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -o', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:264

Util.spawnCommandLineAsyncIO('/usr/bin/lpq -a', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

Automated pattern check.

hans-fritz-pommes · 2026-03-15T18:21:39Z

oups - not intentionally updated my fork

mtwebster · 2026-03-16T16:59:32Z

Should I port to spawnAsyncIO or just leave it?

You can leave as is for now, unless you're already running the latest Cinnamon git master yourself... it's an easy fix down the road. I'm a bit more concerned about the update() flow, between the lpstat -l and -d calls.

I had a graphic generated:

 flowchart TD
      Start["update()"] --> Guard{"updating OR<br/>menu.isOpen OR<br/>removed?"}
      Guard -->|Yes| Bail["return (skip)"]
      Guard -->|No| Init["updating = true<br/>menu.removeAll()<br/>Add 'Printers' item<br/>out1=[] out2='' out3=[]"]

      Init --> LpstatA["<b>lpstat -a</b><br/>(get available printers)"]

      LpstatA -->|error| ErrA["handleError(stderr)<br/>⚠️  menu.removeAll()<br/>updating = false"]
      LpstatA -->|success| StoreOut1["this.out1 = printer list"]

      StoreOut1 --> Fork["<b>⚡ TWO ASYNC CALLS<br/>LAUNCHED IN PARALLEL</b>"]

      Fork --> BranchA["<b>BRANCH A</b><br/>lpstat -l<br/>(tooltip/icon)"]
      Fork --> BranchB["<b>BRANCH B</b><br/>lpstat -d<br/>(default printer)"]

      %% Branch A
      BranchA -->|error| ErrL["handleError(stderr)<br/>⚠️  menu.removeAll()<br/>⚠️  updating = false"]
      BranchA -->|success| IconUpdate["Set tooltip<br/>Set icon based on<br/>⚠️  this.jobs.length<br/>(STALE - not yet
  populated!)"]

      %% Branch B - main chain
      BranchB -->|error| ErrD["handleError(stderr)<br/>⚠️  menu.removeAll()<br/>⚠️  updating = false"]
      BranchB -->|success| Printers["Add separator<br/>Add printer items to menu<br/>Store this.printers"]

      Printers --> LpstatO["<b>lpstat -o</b><br/>(get job list)"]
      LpstatO -->|error| ErrO["handleError(stderr)<br/>updating = false"]
      LpstatO -->|success| Jobs["Store this.out3<br/>Add 'Cancel all' menu<br/>Add cancel submenu"]

      Jobs --> LpqA["<b>lpq -a</b><br/>(get job details)"]
      LpqA -->|error| LpqFail["lpq_present = false<br/>(graceful, no handleError)"]
      LpqA -->|success| LpqOk["lpq_present = true<br/>Parse job info"]

      LpqFail --> BuildJobs
      LpqOk --> BuildJobs

      BuildJobs["Build job menu items<br/>Populate this.jobs[]<br/>⚠️  jobInfo#91;job#93; may be undefined!"] -->
  FinalUI["Set label (job count)<br/>Set visibility<br/>Open submenus<br/><b>updating = false</b>"]

      %% Highlight race conditions
      style Fork fill:#ff6b6b,color:#fff
      style ErrL fill:#ff6b6b,color:#fff
      style IconUpdate fill:#ffaa00,color:#000
      style BuildJobs fill:#ffaa00,color:#000
      style ErrA fill:#ff6b6b,color:#fff
      style ErrD fill:#ff6b6b,color:#fff
      style ErrO fill:#ff6b6b,color:#fff

The Problems Illustrated

Race condition (red nodes): After lpstat -a succeeds, lpstat -l (Branch A) and lpstat -d (Branch B) are launched
simultaneously with no ordering guarantee. Three things can go wrong:

Branch A error destroys Branch B's work: If lpstat -l fails, handleError() calls menu.removeAll() — wiping out
everything Branch B is building or has built. It also sets updating = false, allowing a new update() to start while Branch
B is still running.
Branch A reads stale this.jobs: Branch A sets the icon based on this.jobs.length, but this.jobs is only populated much
later at the end of Branch B's chain (lpq -a callback). So it always uses the previous update cycle's job count.
Double updating = false: If Branch A errors out (setting updating = false) while Branch B is still mid-chain, a new
update() could start, calling menu.removeAll() and clobbering Branch B.

The fix would be to make lpstat -l part of the sequential chain rather than parallel — e.g., call it at the very end after
jobs are populated, which is where the original code had it.

hans-fritz-pommes · 2026-03-17T16:18:09Z

Yes, I was intending to make it faster - which is a very small advantage compared to the possible problems...

changed parallel "lpstat -l"-call to a "linear" call

github-actions · 2026-03-17T16:31:51Z

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 5 potential issue(s):

ℹ️ shell_string_spawn

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:180

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -a', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:191

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -d', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:219

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -o', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:242

Util.spawnCommandLineAsyncIO('/usr/bin/lpq -a', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:309

Util.spawnCommandLineAsyncIO('/usr/bin/lpstat -l', (stdout, stderr, exitCode) => {

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.

Automated pattern check.

hans-fritz-pommes · 2026-03-17T16:33:10Z

Sadly, I don't know how to test the error handling of lpstat -l now. The icon update and tooltip update in case of no errors (only stdout) works.

Fixed ugliness and not-working "cancel all jobs"

7be72e3

hans-fritz-pommes marked this pull request as draft February 1, 2026 19:18

Update applet.js

55ba527

Fix mini-problem (See linuxmint#13524)

hans-fritz-pommes marked this pull request as ready for review February 1, 2026 20:54

hans-fritz-pommes marked this pull request as draft February 2, 2026 12:36

Update applet.js

58917a3

Support filenames with whitespaces

hans-fritz-pommes marked this pull request as ready for review February 2, 2026 14:11

claudiux requested a review from clefebvre February 2, 2026 14:13

mtwebster reviewed Mar 4, 2026

View reviewed changes

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js Outdated Show resolved Hide resolved

mtwebster reviewed Mar 4, 2026

View reviewed changes

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js Outdated Show resolved Hide resolved

mtwebster reviewed Mar 4, 2026

View reviewed changes

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js Outdated Show resolved Hide resolved

Merge branch 'linuxmint:master' into patch-1

6a0e9dc

Update applet.js

16697cc

Improved with mtwebsters ideas (linuxmint#13524)

Update applet.js

a3ced04

removed deprecated lang.bind

hans-fritz-pommes added 2 commits March 9, 2026 17:41

Update applet.js

9c47909

Adressed linuxmint#9265

Update and rename lpstat-a.py to tool.py

b1747aa

Adressing linuxmint#9265 Necessary update to catch the error reason

hans-fritz-pommes requested a review from mtwebster March 9, 2026 16:43

Merge branch 'linuxmint:master' into patch-1

a0414f9

hans-fritz-pommes added 4 commits March 10, 2026 15:52

Update applet.js

8e730a0

improved error handling

Update tool.py

af4bfb2

improved error handling

Update applet.js

b1210e6

added this.removed

Update applet.js

1f7e548

removed unnecessary timeout

Update applet.js

cca1c52

improved looking of error-handling

mtwebster reviewed Mar 10, 2026

View reviewed changes

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js Outdated Show resolved Hide resolved

mtwebster reviewed Mar 10, 2026

View reviewed changes

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js Outdated Show resolved Hide resolved

improved applet.js

fd8f999

- exchanged "Util.spawn_async(...)" & "tool.py" with "Util.spawnCommandLineAsyncIO(...)" - exchanged "GLib.format_size_for_display(...)" with "GLib.format_size(...)" - exchanged "cancel-print-dialog.py" with "ModalDialog.ConfirmDialog"

This comment was marked as outdated.

Sign in to view

Delete printer-applet-tool.py

88be5e2

This comment was marked as outdated.

Sign in to view

Delete printer-applet-cancel-print-dialog.py

41b3024

hans-fritz-pommes requested a review from mtwebster March 11, 2026 20:21

mini update applet.js

43db625

replaced error message cut 69 with 70 removed unnecessary line with printError = falsr;

This comment was marked as outdated.

Sign in to view

Merge branch 'linuxmint:master' into patch-1

d299c0d

Update applet.js

12e6e14

changed parallel "lpstat -l"-call to a "linear" call

Conversation

hans-fritz-pommes commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hans-fritz-pommes commented Feb 1, 2026

Uh oh!

hans-fritz-pommes commented Feb 1, 2026

Uh oh!

hans-fritz-pommes commented Feb 1, 2026

Uh oh!

hans-fritz-pommes commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ lang_bind

Uh oh!

github-actions bot commented Mar 5, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ lang_bind

Uh oh!

hans-fritz-pommes commented Mar 5, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

⚠️ lang_bind

Uh oh!

leigh123linux commented Mar 5, 2026

Uh oh!

mtwebster commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hans-fritz-pommes commented Mar 5, 2026

Uh oh!

hans-fritz-pommes commented Mar 9, 2026

Uh oh!

hans-fritz-pommes commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hans-fritz-pommes commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mtwebster commented Mar 10, 2026

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Mar 11, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

ℹ️ shell_string_spawn

Uh oh!

hans-fritz-pommes commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hans-fritz-pommes commented Mar 11, 2026

Uh oh!

mtwebster commented Mar 11, 2026

Uh oh!

This comment was marked as outdated.

hans-fritz-pommes commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 15, 2026

Best-practices scanner

This check is not perfect will not replace a normal review.

ℹ️ shell_string_spawn

Uh oh!

hans-fritz-pommes commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtwebster commented Mar 16, 2026

The Problems Illustrated

Uh oh!

hans-fritz-pommes commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

hans-fritz-pommes commented Feb 1, 2026 •

edited

Loading

mtwebster commented Mar 5, 2026 •

edited

Loading

hans-fritz-pommes commented Mar 9, 2026 •

edited

Loading

hans-fritz-pommes commented Mar 10, 2026 •

edited

Loading

hans-fritz-pommes commented Mar 11, 2026 •

edited

Loading

hans-fritz-pommes commented Mar 15, 2026 •

edited

Loading