Backport: PopupResizeHandler return correct popup size bugfix #13475
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure correct resize values are returned even if resizing starts and stops without mouse movement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12804 to the 6.4-maintenance branch.
Summary
Cherry-pick of commit 0df121f from master. This fix was merged in May 2025
but was never backported to 6.4.x.
The Bug
When clicking on the menu resize edge without actually moving the mouse
(click and release),
_new_user_widthand_new_user_heightwereuninitialized, causing the menu to shrink unexpectedly.
The Fix
Initialize these values at the start of the drag operation, ensuring correct
sizes are returned even without mouse movement.
Fixes: #12972 (for 6.4.x users)
Related: #12803, #12804
Credit: @fredcw (original fix author)