Fix: Prevent TypeError in network applet when devices is undefined#13444
Open
utilisateursrichard wants to merge 1 commit intolinuxmint:masterfrom
Open
Fix: Prevent TypeError in network applet when devices is undefined#13444utilisateursrichard wants to merge 1 commit intolinuxmint:masterfrom
utilisateursrichard wants to merge 1 commit intolinuxmint:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeError that occurs in the network applet when _connectionRemoved tries to access the devices property without checking if it exists first. This can happen during network state changes such as wake-from-sleep scenarios.
Changes:
- Added null safety check for
this._devices[section]andthis._devices[section].devicesbefore iterating over devices in_connectionRemovedmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
the issue was found in #12721 btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeError that appears in logs (and potentially affects UI rendering) when a connection is removed while
devicesis undefined.The issue:
In
_connectionRemoved, the code accessesdevices.lengthwithout checking ifdevicesexists. This can happen during specific wake-from-sleep scenarios or network resets.The fix:
Added a null check (
if (devices)) before iterating over the devices list.Verification:
Tested locally on Linux Mint. The error no longer appears in logs when network state changes.
issue found here : #12721