perf: reduce allocations in render and preview paths#60
Merged
Conversation
flexiondotorg
commented
Jul 5, 2026
flexiondotorg
commented
Contributor
- Reuse unread audio samples in the streaming reader instead of trimming slices.
- Precompute bar scanlines and split swscale upload from scaling work.
- Send pre-rendered preview strings at a fixed cadence, and update UI tests.
- Refresh the architecture note for the new preview cadence.
- Add benchmarks for preview rendering and reader throughput.
- Reuse unread audio samples in the streaming reader instead of trimming slices. - Precompute bar scanlines and split swscale upload from scaling work. - Send pre-rendered preview strings at a fixed cadence, and update UI tests. - Refresh the architecture note for the new preview cadence. - Add benchmarks for preview rendering and reader throughput. Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 14 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Performance refactoring: audio reader buffer reuse, precomputed bar scanlines, and pre-rendered preview strings. All changes are isolated and covered by updated tests.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.