refactor: apply peer review findings across codebase#49
Conversation
flexiondotorg
commented
Jul 4, 2026
flexiondotorg
commented
- Rename internal/id3 to internal/artwork and fold TagInfo into encoder.Metadata
- Update help printer to show real flag defaults and use kong.HelpPrinter signature
- Add colorprofile support to CLI output so pipes render plain text
- Move PrintWarning to stderr; update related output messages
- Register JPEG and GIF cover input support in artwork scaling
- Collapse vestigial cover-art goroutine (remove coverArtResult type)
- Rename embedMetadata to extractStats for clarity
- Drive MP3 lowpass cutoff from preset.lowpassHz field
- Write podcast_duration as quoted value in Hugo frontmatter
- Add self-sufficient stats integration test
- Update .gitignore: whitelist tracked test fixtures, ignore coverage.out
- Pin gocyclo and ineffassign versions in CI
- Add help render tests; expand encoder and metadata tests
- Fix grammar and cross-references in documentation (README, AGENTS.md, flake.nix)
- Update .harper-dictionary.txt for prose clarity
- Rename internal/id3 to internal/artwork and fold TagInfo into encoder.Metadata - Update help printer to show real flag defaults and use kong.HelpPrinter signature - Add colorprofile support to CLI output so pipes render plain text - Move PrintWarning to stderr; update related output messages - Register JPEG and GIF cover input support in artwork scaling - Collapse vestigial cover-art goroutine (remove coverArtResult type) - Rename embedMetadata to extractStats for clarity - Drive MP3 lowpass cutoff from preset.lowpassHz field - Write podcast_duration as quoted value in Hugo frontmatter - Add self-sufficient stats integration test - Update .gitignore: whitelist tracked test fixtures, ignore coverage.out - Pin gocyclo and ineffassign versions in CI - Add help render tests; expand encoder and metadata tests - Fix grammar and cross-references in documentation (README, AGENTS.md, flake.nix) - Update .harper-dictionary.txt for prose clarity Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 28 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Major refactor of the core architecture affecting business logic and CLI output; requires human review.
Re-trigger cubic
- Reword ID3-only doc comments to describe muxer-native tagging (MP3/AAC/Opus) - Correct stale bitrate comment in preset struct (now holds Opus VBR targets too) - Expand missing why comments in speed calculation and stats extraction - Collapse wordy comments and remove self-evident narration Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 8 files (changes from recent commits).
Requires human review: Significant structural refactor with package renames and type moves that changes data flow and encoder setup. High risk of subtle breakage; should be reviewed by a human.
Re-trigger cubic
- remove duplicated markdown, colour writer, and speed label helpers - tidy cover art path resolution and image encoding paths - refresh AGENTS.md notes for the updated preset table Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 12 files (changes from recent commits).
Auto-approved: Refactor internal packages, replace TagInfo with encoder.Metadata, add colorprofile and help tests, update CI and docs.
Re-trigger cubic
Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
cubic-dev-ai
Bot
dismissed
their stale review
Dismissed because Cubic found issues in a newer review.
Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: This is a large architectural refactor that changes core structure and CLI output. AI review found no issues, but the scope and complexity require human judgment to avoid regressions.
Re-trigger cubic
1 participant
