feat: add /lfx-intercom skill for LFX Intercom integration#8
Open
mlehotskylf wants to merge 2 commits intomainfrom
Open
feat: add /lfx-intercom skill for LFX Intercom integration#8mlehotskylf wants to merge 2 commits intomainfrom
mlehotskylf wants to merge 2 commits intomainfrom
Conversation
Adds a new skill that adds or fixes Intercom integration in any LFX Angular app, standardizing against the canonical pattern validated across Mentorship, Crowdfunding, and PCC. Key features: - Audit-first flow: produces a gap report before making any changes - Full IntercomService implementation (Promise-based boot, isLoaded/ isBooted/isLoading state, Intercom stub queue, JWT pre-set and stripped from boot options, SSR-safe window guards) - App component wiring with intercomBootAttempted guard - Auth0 configuration guide (custom_claims.js case block, secret location, Terraform deployment steps) - Complete CSP entries including WebSocket sources for real-time chat - Notes on 127.0.0.1 local dev requirement, hostname registration, and deprecated HMAC claim - Self-maintenance strategy: canonical reference app + update-in-same-PR rule Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new /lfx-intercom skill to standardize (or repair) Intercom integration across LFX Angular apps, and documents it in the repository skill index.
Changes:
- Introduces
lfx-intercom/SKILL.mdwith an audit-first workflow plus canonical implementation guidance (service, app wiring, Auth0 claim, CSP). - Updates
README.mdto list/lfx-intercomin the skill list, overview table, and project structure tree.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lfx-intercom/SKILL.md | New skill definition and end-to-end Intercom integration/audit instructions |
| README.md | Adds /lfx-intercom to the documented skill catalog and repo structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add missing copyright + SPDX header after front matter (matches all other skills in the repo) - Note that the environment import path must be adjusted based on the chosen service folder depth Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/lfx-intercomskill that adds or fixes Intercom integration in any LFX Angular appWhat the skill does
Audit-first: produces a gap report against 11 checks before touching any code — exits cleanly if nothing is wrong.
IntercomService (canonical, production-proven):
boot()withisLoaded/isBooted/isLoadingstatei.q) so commands work before the real script loadswindow.intercomSettingsand stripped from boot options (not leaked into payload)typeof windowguards on every methodonerrorhandler, 10s timeout with CSP/ad-blocker hintApp component wiring:
intercomBootAttemptedguard (prevents re-boot on multipleuserProfile$emissions)enable-intercomflag patternAuth0 configuration (required, commonly missed):
custom_claims.jscase block to addCSP: complete entry set including WebSocket sources (
wss://) required for real-time chat.Notes:
127.0.0.1local dev requirement, new hostname registration (contact Heather's team), deprecated HMAC claim guidance.Self-maintenance: designates Mentorship as canonical reference; requires updating this skill in the same PR where the app is fixed.
Test plan
./install.shand confirm/lfx-intercomappears in the skill list/lfx-intercom— confirm it asks context questions and produces an audit reportIntercomServicematches the implementation inlfx-mentorship-upgrade/src/app/services/intercom.service.ts🤖 Generated with Claude Code