Skip to content

Update comment message, add test case, fix vulnerablities#4937

Open
lukaszgryglicki wants to merge 2 commits intomainfrom
unicron-add-remove-co-authored-by-option-prod
Open

Update comment message, add test case, fix vulnerablities#4937
lukaszgryglicki wants to merge 2 commits intomainfrom
unicron-add-remove-co-authored-by-option-prod

Conversation

@lukaszgryglicki
Copy link
Member

Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io

Assisted by OpenAI

Assisted by GitHub Copilot

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
@lukaszgryglicki lukaszgryglicki self-assigned this Mar 17, 2026
Copilot AI review requested due to automatic review settings March 17, 2026 07:43
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 06c0e421-24dd-4cb9-8a0e-737bddd98ff9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch unicron-add-remove-co-authored-by-option-prod
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates dependency locks/overrides to address vulnerability findings, expands/aligns API route sanitization logic across multiple helper tools and services, and reduces sensitive details in backend logging/error paths.

Changes:

  • Add/extend route sanitization patterns (Swagger resource collapsing, undefined, specific route patterns) across Python/Go utilities and backend telemetry.
  • Introduce a new Datadog “aggregate API” script for faster per-route usage reporting, plus an optional --sanitize-routes flag in the existing script.
  • Update dependency versions/lockfiles and tighten logging/error messages to avoid leaking details.

Reviewed changes

Copilot reviewed 19 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yarn.lock Updates JS dependency resolutions/URLs and bumps some transitive versions.
utils/otel_dd/api_usage_stats_ddog.py Adds optional client-side route sanitization and CLI flag.
utils/otel_dd/api_usage_stats_ddog_aggregate.py New aggregate-mode Datadog usage stats script with optional sanitization and concurrency.
utils/otel_dd_py/otel_dd.py Extends local sanitizer patterns to match backend templating.
utils/otel_dd_go/otel_dd.go Extends local sanitizer patterns to match backend templating.
utils/count_apis.sh Aligns offline log route normalization rules with backend/OTel templating.
tests/rest/package.json Upgrades newman and switches dependency pin mechanism to overrides.
tests/functional/yarn.lock Updates lockfile entries as part of dependency refresh.
package.json Adds explicit deps for minimatch/validator (likely for audit remediation).
package-lock.json New npm lockfile capturing resolved dependency graph for the root package.
cla-backend/yarn.lock Updates backend JS lockfile entries (e.g., tar/simple-git adjustments).
cla-backend/requirements.txt Bumps Python cryptography version.
cla-backend/package.json Updates tar version constraint.
cla-backend/cla/utils.py Reduces sensitive logging, adjusts GitLab member lookup error handling, and hardens PR-number extraction.
cla-backend/cla/tests/unit/test_user_commit_summary.py Updates unit test expectation for new co-author guidance text.
cla-backend/cla/routes.py Aligns backend route sanitizer with updated templating patterns and fixes numeric-id masking loop.
cla-backend/cla/models/github_models.py Reduces sensitive logging and makes OAuth/session handling more robust.
cla-backend-go/yarn.lock Updates Go backend JS lockfile entries (tar/simple-git/debug changes).
cla-backend-go/v2/sign/jwt.go Migrates JWT import to github.com/golang-jwt/jwt/v4.
cla-backend-go/telemetry/datadog_otlp.go Aligns HTTP route sanitization with updated templating patterns.
cla-backend-go/package.json Updates simple-git resolution and tar resolution constraints.
cla-backend-go/go.sum Refreshes sums after JWT module/version updates.
cla-backend-go/go.mod Adds toolchain directive and updates JWT + otel trace requirement classification.
cla-backend-go/github/github_repository.go Adds co-author removal guidance to comment template text.
cla-backend-go/github/github_repository_test.go Adds tests covering new co-author removal guidance behavior.
.gitignore Ignores additional build artifacts (Go binaries, bin/*, api usage CSV patterns).
Files not reviewed (1)
  • tests/rest/package-lock.json: Language not supported

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants