Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: vulnerability scanning within git integration (IN-956) #3892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: vulnerability scanning within git integration (IN-956) #3892
Changes from all commits
803e49e28a077bbcf68d339f8935ed3308aa6c7fd4fda4ee8670e7791458167572449e91403d56c57c4a7ec4c04b4e9df5689d394File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdin_input silently dropped when stderr_logger is provided
Medium Severity
When
stderr_loggeris provided, the_run_with_stderr_loggingpath reads stdout and streams stderr but never writesstdin_inputto the process. Theprocess.communicate(input=stdin_input)call only exists in theelsebranch. Any caller combiningstderr_loggerwithinput_textwill silently lose the stdin data. While the vulnerability scanner doesn't currently useinput_text, this is a general-purpose utility function shared across services.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.