Skip to content

Comments

chore: Unify linglong.yaml#423

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
wangrong1069:pr0212
Feb 12, 2026
Merged

chore: Unify linglong.yaml#423
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
wangrong1069:pr0212

Conversation

@wangrong1069
Copy link
Contributor

@wangrong1069 wangrong1069 commented Feb 12, 2026

  • Update linglong base and runtime to 25.2.2.
  • Use buildext and apt install --download-only instead of sources to download dependency packages.

Log: Unify linglong.yaml
Task: https://pms.uniontech.com/task-view-386771.html

Summary by Sourcery

Update linglong packaging to use the latest base/runtime and centralized configuration.

Enhancements:

  • Bump linglong base and runtime versions from 25.2.1 to 25.2.2.
  • Replace the long static deb sources list with an apt-based dependency download flow using build extensions.
  • Unify architecture-specific linglong.yaml files into a single configuration and refresh copyright years in metadata.

- Update linglong base and runtime to 25.2.2.
- Use buildext and `apt install --download-only` instead of sources to download dependency packages.

Log: Unify linglong.yaml
Task: https://pms.uniontech.com/task-view-386771.html
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates linglong packaging to use base/runtime 25.2.2 and unified single linglong.yaml that pulls build-time dependencies via apt instead of embedding a massive explicit sources list per-arch.

Sequence diagram for updated linglong build dependency resolution via apt

sequenceDiagram
    participant Builder
    participant LinglongConfig
    participant Apt as AptRepo
    participant AptCache as AptCacheDir
    participant InstallDepScript as InstallDep

    Builder->>LinglongConfig: Read linglong.yaml
    LinglongConfig-->>Builder: base 25.2.2, runtime 25.2.2, buildext apt

    Builder->>Apt: apt update
    Builder->>Apt: apt install --download-only <qt6_and_other_build_deps>
    Apt-->>AptCache: Store .deb files in /var/cache/apt/archives

    Builder->>InstallDepScript: bash ./install_dep /var/cache/apt/archives "$PREFIX"
    InstallDepScript->>AptCache: Scan downloaded .deb files
    InstallDepScript-->>Builder: Dependencies installed into PREFIX

    Note over Builder,AptCache: Previous flow used explicit sources list of .deb URLs per arch in linglong.yaml
Loading

File-Level Changes

Change Details Files
Update linglong package metadata and base/runtime versions.
  • Extend SPDX copyright years from 2023-2024 to 2023-2026 in linglong.yaml header.
  • Bump base from org.deepin.base/25.2.1 to org.deepin.base/25.2.2.
  • Bump runtime from org.deepin.runtime.webengine/25.2.1 to org.deepin.runtime.webengine/25.2.2.
linglong.yaml
Simplify dependency acquisition by switching from explicit sources list to apt-based downloads with buildext.
  • Replace custom install_dep invocation that referenced a linglong/sources directory with an apt-based workflow using apt -y install --download-only for all required Qt/DTK/testing/encoding/icu/event-log packages, followed by bash ./install_dep /var/cache/apt/archives "$PREFIX".
  • Remove the gigantic sources: section that hard‑coded hundreds of .deb URLs and digests.
  • Introduce a buildext.apt.build_depends section to allow apt usage in build and permit apt update during builds.
linglong.yaml
Unify per-architecture packaging into a single linglong.yaml.
  • Delete architecture-specific linglong.yaml files under arm64/, loong64/, mips64/, and sw64/ in favor of the top-level unified linglong.yaml.
arm64/linglong.yaml
loong64/linglong.yaml
mips64/linglong.yaml
sw64/linglong.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Now that dependency acquisition is done via apt install --download-only, consider pinning package versions (e.g. via =version or an apt pin file) to preserve the previous level of build reproducibility that the explicit sources list provided.
  • The new apt usage in the build section assumes a configured sources list and interactive defaults; if this runs in a minimal CI/container, you may want to add an explicit apt update and set DEBIAN_FRONTEND=noninteractive to make builds more robust.
  • With the removal of per-architecture linglong.yaml files, double-check whether any arch-specific overrides (e.g. different dependencies or base/runtime versions) are still required and, if so, consolidate them via conditional logic or variables in the unified file.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Now that dependency acquisition is done via `apt install --download-only`, consider pinning package versions (e.g. via `=version` or an apt pin file) to preserve the previous level of build reproducibility that the explicit `sources` list provided.
- The new `apt` usage in the `build` section assumes a configured sources list and interactive defaults; if this runs in a minimal CI/container, you may want to add an explicit `apt update` and set `DEBIAN_FRONTEND=noninteractive` to make builds more robust.
- With the removal of per-architecture `linglong.yaml` files, double-check whether any arch-specific overrides (e.g. different dependencies or base/runtime versions) are still required and, if so, consolidate them via conditional logic or variables in the unified file.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 05ede29 into linuxdeepin:master Feb 12, 2026
21 checks passed
@wangrong1069 wangrong1069 deleted the pr0212 branch February 12, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants