chore: Unify linglong.yaml#423
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Feb 12, 2026
Merged
Conversation
- Update linglong base and runtime to 25.2.2. - Use buildext and `apt install --download-only` instead of sources to download dependency packages. Log: Unify linglong.yaml Task: https://pms.uniontech.com/task-view-386771.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates linglong packaging to use base/runtime 25.2.2 and unified single linglong.yaml that pulls build-time dependencies via apt instead of embedding a massive explicit sources list per-arch. Sequence diagram for updated linglong build dependency resolution via aptsequenceDiagram
participant Builder
participant LinglongConfig
participant Apt as AptRepo
participant AptCache as AptCacheDir
participant InstallDepScript as InstallDep
Builder->>LinglongConfig: Read linglong.yaml
LinglongConfig-->>Builder: base 25.2.2, runtime 25.2.2, buildext apt
Builder->>Apt: apt update
Builder->>Apt: apt install --download-only <qt6_and_other_build_deps>
Apt-->>AptCache: Store .deb files in /var/cache/apt/archives
Builder->>InstallDepScript: bash ./install_dep /var/cache/apt/archives "$PREFIX"
InstallDepScript->>AptCache: Scan downloaded .deb files
InstallDepScript-->>Builder: Dependencies installed into PREFIX
Note over Builder,AptCache: Previous flow used explicit sources list of .deb URLs per arch in linglong.yaml
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that dependency acquisition is done via
apt install --download-only, consider pinning package versions (e.g. via=versionor an apt pin file) to preserve the previous level of build reproducibility that the explicitsourceslist provided. - The new
aptusage in thebuildsection assumes a configured sources list and interactive defaults; if this runs in a minimal CI/container, you may want to add an explicitapt updateand setDEBIAN_FRONTEND=noninteractiveto make builds more robust. - With the removal of per-architecture
linglong.yamlfiles, double-check whether any arch-specific overrides (e.g. different dependencies or base/runtime versions) are still required and, if so, consolidate them via conditional logic or variables in the unified file.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that dependency acquisition is done via `apt install --download-only`, consider pinning package versions (e.g. via `=version` or an apt pin file) to preserve the previous level of build reproducibility that the explicit `sources` list provided.
- The new `apt` usage in the `build` section assumes a configured sources list and interactive defaults; if this runs in a minimal CI/container, you may want to add an explicit `apt update` and set `DEBIAN_FRONTEND=noninteractive` to make builds more robust.
- With the removal of per-architecture `linglong.yaml` files, double-check whether any arch-specific overrides (e.g. different dependencies or base/runtime versions) are still required and, if so, consolidate them via conditional logic or variables in the unified file.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
lzwind
approved these changes
Feb 12, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apt install --download-onlyinstead of sources to download dependency packages.Log: Unify linglong.yaml
Task: https://pms.uniontech.com/task-view-386771.html
Summary by Sourcery
Update linglong packaging to use the latest base/runtime and centralized configuration.
Enhancements: