fix: decouple specialCpuTarGzCompressor dconfig read from m_isOrderMode gate - #467
Open
add-uos wants to merge 1 commit into
Open
fix: decouple specialCpuTarGzCompressor dconfig read from m_isOrderMode gate#467add-uos wants to merge 1 commit into
add-uos wants to merge 1 commit into
Conversation
…de gate The CPU thread count config (specialCpuTarGzCompressor) for tar.gz was gated behind m_isOrderMode, which defaults to false because specialCustomizedType defaults to -1. This caused the dconfig value to never be read, so the UI always fell back to max threads (8) regardless of the configured value. Fix by reading specialCpuTarGzCompressor independently of m_isOrderMode in both refreshCompressLevel() and slotAdvancedEnabled(). Also remove the duplicate dead-code tar.gz branch in refreshCompressLevel(). Log: fix tar.gz CPU thread count not applying from dconfig Bug: https://pms.uniontech.com/bug-view-273093
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDecouples tar.gz CPU thread count configuration from the m_isOrderMode gate so the dconfig value is always applied when available, and removes redundant dead code for tar.gz handling. Sequence diagram for applying tar.gz CPU configurationsequenceDiagram
participant CompressSettingPage
participant DConfig
participant CpuComboBox
CompressSettingPage->>CompressSettingPage: refreshCompressLevel(strType)
alt strType == tar.gz
CompressSettingPage->>DConfig: isValid()
CompressSettingPage->>DConfig: keyList()
DConfig-->>CompressSettingPage: specialCpuTarGzCompressor available
CompressSettingPage->>DConfig: value(specialCpuTarGzCompressor)
DConfig-->>CompressSettingPage: CPU thread index
CompressSettingPage->>CpuComboBox: setCurrentIndex(nCpu)
end
CompressSettingPage->>CompressSettingPage: slotAdvancedEnabled(bEnabled)
alt tar.gz selected
CompressSettingPage->>CpuComboBox: setCurrentIndex(count() - 1)
CompressSettingPage->>DConfig: value(specialCpuTarGzCompressor)
DConfig-->>CompressSettingPage: CPU thread index
CompressSettingPage->>CpuComboBox: setCurrentIndex(nCpu)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: decouple specialCpuTarGzCompressor dconfig read from m_isOrderMode gate
The CPU thread count config (specialCpuTarGzCompressor) for tar.gz was
gated behind m_isOrderMode, which defaults to false because
specialCustomizedType defaults to -1. This caused the dconfig value to
never be read, so the UI always fell back to max threads (8) regardless
of the configured value.
Fix by reading specialCpuTarGzCompressor independently of m_isOrderMode
in both refreshCompressLevel() and slotAdvancedEnabled(). Also remove
the duplicate dead-code tar.gz branch in refreshCompressLevel().
Log: fix tar.gz CPU thread count not applying from dconfig
Bug: https://pms.uniontech.com/bug-view-273093
Summary by Sourcery
Apply tar.gz CPU thread settings independently of order mode so configured values are honored consistently.
Bug Fixes:
Enhancements: