Skip to content

chore(debian): update version to 0.3.3#87

Merged
zccrs merged 1 commit intolinuxdeepin:masterfrom
wineee:deb
Feb 28, 2026
Merged

chore(debian): update version to 0.3.3#87
zccrs merged 1 commit intolinuxdeepin:masterfrom
wineee:deb

Conversation

@wineee
Copy link
Member

@wineee wineee commented Feb 28, 2026

log: new tag

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @wineee, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@github-actions
Copy link

TAG Bot

TAG: 0.3.3
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

deepin pr auto review

这段代码变更主要涉及版本号的更新和 changelog 的维护。作为一个代码审查助手,我将从以下几个方面提出改进意见:

1. 语法逻辑与代码质量

CMakeLists.txt:

  • 版本号更新: VERSION 0.3.1 -> VERSION 0.3.3 的更新是正确的,与 changelog 保持一致。
  • 建议: 考虑将版本号定义为变量,以便在多个文件中统一管理,例如:
    set(PROJECT_VERSION_MAJOR 0)
    set(PROJECT_VERSION_MINOR 3)
    set(PROJECT_VERSION_PATCH 3)
    project(DDM VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH} LANGUAGES CXX C)

debian/changelog:

  • 格式正确: changelog 遵循了 Debian 的标准格式。
  • 条目清晰: 每个变更都有明确的类型标记(chore/feat/fix)和描述。

2. 代码性能

  • 无直接影响: 版本号和 changelog 的更新对运行时性能没有直接影响。

3. 代码安全

  • 版权年份: changelog 中提到 "update copyright to 2026",但当前日期是 2023 年,提前更新到 2026 年可能是不合理的,除非有特殊原因。
  • 建议: 确认版权年份的更新是否符合项目规划,避免未来维护时的混淆。

4. 其他建议

  • 版本号一致性: 确保所有相关文件(如 CMakeLists.txt, debian/changelog, spec 文件等)中的版本号保持一致。
  • changelog 细节:
    • fix: avoid mistakenly create seat group on debian-based systems 的描述可以更具体,例如说明在什么情况下会误创建 seat group。
    • chore: replace org.freedesktop.login1 D-Bus call with sd-login API 是一个较大的变更,建议在 changelog 中补充说明替换的原因(如性能、兼容性等)。

5. 潜在问题

  • 版本跳跃: 从 0.3.1 直接跳到 0.3.3,中间跳过了 0.3.2。如果 0.3.2 已经发布,这是合理的;否则,建议确认是否遗漏了版本号。

总结

这段代码变更整体是合理的,但建议:

  1. 检查版权年份的更新是否合理。
  2. 确认版本号的一致性和连续性。
  3. 补充 changelog 中某些变更的详细说明。

如果需要进一步优化,可以考虑将版本号集中管理,并确保所有相关文件的版本号同步更新。

@zccrs zccrs merged commit bf5f9a6 into linuxdeepin:master Feb 28, 2026
10 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Feb 28, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 0.3.3
  • Tag SHA: f0b0d595ca0cf64eca94761b7b1bc5b76c9824a7
  • Commit SHA: 37da832bfbce4800867cb362417dcde5604ae7d7
  • Tag Message:
    Release ddm 0.3.3
    
    
  • Tagger:
    • Name: wineee
  • Distribution: unstable

@wineee wineee deleted the deb branch February 28, 2026 06:21
@wineee wineee restored the deb branch February 28, 2026 06:25
@wineee wineee deleted the deb branch February 28, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants