Skip to content

sync: from linuxdeepin/dde-session-shell#519

Open
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-73-nosync
Open

sync: from linuxdeepin/dde-session-shell#519
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-73-nosync

Conversation

@deepin-ci-robot

@deepin-ci-robot deepin-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#73

Summary by Sourcery

Align licensing and compliance metadata with upstream for session shell components.

Documentation:

  • Add SPDX license headers to mfasequencecontrol source and header files.

Chores:

  • Replace REUSE.toml with a .reuse/dep5 configuration file to adjust REUSE licensing metadata.

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Syncs licensing metadata with upstream by adding SPDX headers to MFA sequence control sources and switching from REUSE.toml to a .reuse/dep5-based configuration.

File-Level Changes

Change Details Files
Add SPDX license and copyright headers to MFA sequence control implementation and header.
  • Insert SPDX-FileCopyrightText comment for UnionTech Software Technology Co., Ltd.
  • Specify GPL-3.0-or-later license via SPDX-License-Identifier in both implementation and header files
src/session-widgets/mfasequencecontrol.cpp
src/session-widgets/mfasequencecontrol.h
Switch REUSE licensing configuration from REUSE.toml to .reuse/dep5.
  • Remove existing REUSE.toml configuration file
  • Add new .reuse/dep5 configuration file for REUSE compliance
REUSE.toml
.reuse/dep5

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The SPDX-FileCopyrightText year is set to 2026 in the new headers; please double-check that this future date is intentional and aligns with the rest of the project’s licensing metadata.
  • Now that REUSE.toml has been removed in favor of .reuse/dep5, verify that the DEP5 configuration fully covers these files and is consistent with the existing REUSE setup in other parts of the repository.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The SPDX-FileCopyrightText year is set to 2026 in the new headers; please double-check that this future date is intentional and aligns with the rest of the project’s licensing metadata.
- Now that REUSE.toml has been removed in favor of .reuse/dep5, verify that the DEP5 configuration fully covers these files and is consistent with the existing REUSE setup in other parts of the repository.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#73
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码完成了许可证格式迁移及SPDX头补充,格式规范且无任何风险
逻辑正确且无安全漏洞,满分通过

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

本次提交仅涉及纯文本文件的添加与删除,以及C++源文件中SPDX注释头的补充,不包含任何可执行逻辑代码变更,不存在语法或逻辑错误
建议:保持现有的许可证声明一致性

  • 2.代码质量(良好)✓

从REUSE.toml格式平滑迁移至.reuse/dep5格式,符合REUSE规范标准;SPDX头信息格式正确,版权年份与归属声明清晰
建议:后续新增文件时继续严格遵循此SPDX头格式规范

  • 3.代码性能(无性能问题)✓

纯配置与许可证文本变更,不产生任何运行时开销或系统调用
建议:无需优化

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次变更为纯文本与注释级别的许可证合规性调整,不涉及内存操作、输入处理或权限变更,无任何攻击面

  • 建议:继续保持对第三方许可证文本完整性的校验,防止恶意篡改

■ 【改进建议代码示例】

无,当前代码已完全符合规范,无需修改。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant