BUGFIX: Revert "modules/coreboot: set Dasharo coreboot fork rev to the main d… #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asharo branch" This reverts commit 13f8cce. Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Collaborator
Author
|
For details see matrix discussion |
Collaborator
|
@tlaurion Sorry for this. We have concluded, then, that we should then stay on the already tested coreboot revision. We are tagging it on our side in the coreboot repo, to ensure it remains there. We will come back with buming the Dasharo/coreboot revision for all affected boards in the next cycle then. |
Collaborator
Author
|
I will retest on v560tu with produced Circleci version, reinstall qubesos and conclude if ok or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…asharo branch"
This reverts commit 13f8cce.
Reverts #1889
Unfortunately, on 3 attempts I was not able to either boot QubesOS 4.2.3 first stage, or install templates on second stage on v560tu.
Also my nv41 "instant rebooted today". Which never happened before, while running on this commit.
Strategy will be to create another branch of #1875 with the changes in, and revert this as well under #1875 to test this properly.