coreboot+linux modules: add helpers to edit config, save in oldconfig/defconfig #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JonathonHall-Purism
left a comment
JonathonHall-Purism
left a comment
There was a problem hiding this comment.
Just one tiny nitpick, looks great and super handy 🥳
…ldconfig/defconfig) Most useful to me are: coreboot.modify_and_save_defconfig_in_place coreboot.modify_and_save_oldconfig_in_place linux.modify_and_save_oldconfig_in_place linux.modify_and_save_defconfig_in_place Which permit to take current in tree configs and translate them into other format. This is useful when trying to version bump and build. Also add helpers to save in versioned version to facilitate change tracking: linux.generate_and_save-versioned-oldconfig linux.regenerate_and_save_versioned_defconfig
tlaurion
force-pushed
the
coreboot+linux_helpers_for_version_bump
branch
from
33b7265 to
a29c277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper tools borrowed from #1351
Will help me bumping 4.14 kernel configs straight to 5.10 with minimal changes and help other do so in the future.
The way I use them is the following:
make BOARD=xyz linux.modify_and_save_oldconfig_in_place: takes the in tree linux board config, modifies it through menuconfig (or not) and saves its oldconfig (full format) back in tree.make BOARD=xyz linux.modify_defconfig_in_place: takes the in tree linux board config, modifies it through menuconfig (or not) and saves its defconfig (variation from defaults for arch) back in tree.Same applies with
make BOARD=xyz coreboot.modify_and_save_oldconfig_in_placeandmake BOARD=xyz coreboot.modify_defconfig_in_place@JonathonHall-Purism doesn't impact anything else then dev/maintenance cycle