Skip to content

solidigm: fix unchecked return value in ilog_dump_pel() #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahmed-ibm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solidigm: fix unchecked return value in ilog_dump_pel() #3972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions plugins/solidigm/solidigm-internal-logs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,16 +808,18 @@ static int ilog_dump_pel(struct libnvme_transport_handle *hdl, struct ilog *ilog
err = nvme_get_log_persistent_event(hdl, NVME_PEVENT_LOG_READ,
pevent_log_full, lp.buffer_size);
if (err)
return err;
goto out;

@igaw igaw Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary because the err label just does a return err?


ilog->count++;

err = log_save(&lp, ilog->cfg->out_dir, "log_pages", "lid_0x0d_lsp_0x00_lsi_0x0000.bin",
pevent_log_full, lp.buffer_size);
if (err)
goto out;

@igaw igaw Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, can't this just be a return err?


nvme_get_log_persistent_event(hdl, NVME_PEVENT_LOG_RELEASE_CTX,
pevent, sizeof(*pevent));

err = nvme_get_log_persistent_event(hdl, NVME_PEVENT_LOG_RELEASE_CTX,

@igaw igaw Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this could be just return nvme_get_log_persistentent_event, no?

pevent, sizeof(*pevent));
out:
return err;
}

Expand Down