wdc: fix null pointer dereference in get_dev_mgmt_log_page_lid_data()#3579
Open
LJaved-IBM wants to merge 1 commit into
Open
wdc: fix null pointer dereference in get_dev_mgmt_log_page_lid_data()#3579LJaved-IBM wants to merge 1 commit into
LJaved-IBM wants to merge 1 commit into
Conversation
The get_dev_mgmt_log_page_lid_data() function initializes @sph to a pointer derived from @DaTa before passing it to wdc_get_dev_mng_log_entry(). However, that function immediately sets *p_p_found_log_entry to NULL, making the initial value of @sph irrelevant and leaving a potentially misleading non-NULL value before the call. The Clang static analyzer flags this as a null pointer dereference since @sph may be NULL when dereferenced after the function call. Initialize @sph to NULL before the call to make the intent clear and suppress the false dereference warning. Signed-off-by: Laraib Javed <laraibjaved@ibm.com>
Collaborator
|
Could you rebase this change, there is merge conflict. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_dev_mgmt_log_page_lid_data() function initializes @sph to
a pointer derived from @DaTa before passing it to
wdc_get_dev_mng_log_entry(). However, that function immediately
sets *p_p_found_log_entry to NULL, making the initial value of
@sph irrelevant and leaving a potentially misleading non-NULL
value before the call.
The Clang static analyzer flags this as a null pointer dereference
since @sph may be NULL when dereferenced after the function call.
Initialize @sph to NULL before the call to make the intent clear
and remove the now-redundant null check in wdc_get_dev_mng_log_entry().
Signed-off-by: Laraib Javed laraibjaved@ibm.com