Minor cleanup for Windows support#3372
Open
bgoing-micron-oss wants to merge 2 commits into
Open
Conversation
Contributor
bgoing-micron-oss
commented
May 19, 2026
bgoing-micron-oss
commented
- Replaces single use of uint with __u32 for better consistency and compatibility.
- Cleans up Windows check in endian.h.
Replaces the one use of uint with __u32 for consistency and better cross-platform compatibility. This was the only use of the uint type name in the entire project. Signed-off-by: Broc Going <bgoing@micron.com>
Windows defines _WIN32 for all Windows platforms, including 64-bit Windows platforms. _WIN64 is then defined as a 0 or 1 to indicate whether the platform is 32 or 64 bit. The check for defined(_WIN64) is redundant, since any time _WIN64 is defined, _WIN32 is also defined. Windows documentation recommends using _WIN32 when checking for Windows. Removes the redundant _WIN64 check in favor of the more standard check of just _WIN32. Signed-off-by: Broc Going <bgoing@micron.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.