mem-win: Disable Windows min/max macros in favor of project solutions#3371
Open
bgoing-micron-oss wants to merge 1 commit into
Open
mem-win: Disable Windows min/max macros in favor of project solutions#3371bgoing-micron-oss wants to merge 1 commit into
bgoing-micron-oss wants to merge 1 commit into
Conversation
Disables definitions of min/max macros coming from Windows includes. Favors local solutions for min/max definitions isntead. - Removes #ifndef guards around min/max in common.h that were added due to Windows default min/max definitions. - Updates mem-win.c to use ccan/minmax definitions. Signed-off-by: Broc Going <bgoing@micron.com>
Contributor
Author
|
@igaw I found a way to disable the Windows min/max macros that were conflicting with the min/max macros already being defined and used in the project. I've backed out the workaround in common.h, and updated the existing Windows code to use ccan/minmax instead where needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables definitions of min/max macros coming from Windows includes. Favors local solutions for min/max definitions isntead.